Refactor TypedFunction, ObjectProcessor, and ObjectProcessorFunctions #4992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* io.deephaven.functions: extensions/protobuf -> java/functions * io.deephaven.processor: extensions/kafka -> java/processor * io.deephaven.processor.functions: extensions/kafka -> java/processor-functions Introduced top-level directory `java/`, with the hopes of having it become the directory for new projects ala deephaven#4991
devinrsmith
added
clean up
NoDocumentationNeeded
NoReleaseNotesNeeded
rcaudy
reviewed
Dec 29, 2023
java/processor-functions/src/main/java/io/deephaven/processor/functions/ChunkUtils.java
Outdated
Show resolved
Hide resolved
|
This is now a breaking change w/ the rename from |
|
Planned follow-up wrt changes to SafeCloseable / moving of |
rcaudy
reviewed
Jan 19, 2024
engine/processor/src/main/java/io/deephaven/processor/ObjectProcessor.java
Show resolved
Hide resolved
extensions/kafka/src/main/java/io/deephaven/kafka/ingest/FieldCopierAdapter.java
Outdated
Show resolved
Hide resolved
rcaudy
previously approved these changes
Jan 19, 2024
rcaudy
approved these changes
Jan 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
io.deephaven.functionsrenamed toio.deephaven.function, moved tofunction/,functionprojectio.deephaven.processormoved toengine/processor/,engine-processorprojectio.deephaven.processor.functionsmoved toengine/processor-functions/,engine-processor-functionsprojectWould like eventual follow-up for
function/to more appropriate place, ala #4991